Files
codex-app-server/cloud/tests/test_skill_seed_worker.py
openqj 7b537c31a6 test: close unclosed file handles in tests (Path read/write)
Replace bare open().read()/write() in tests with Path.read_text/
write_text (or json.loads over read_text); the five remaining
open(...).close() empty-file creations become Path.write_text('').
No assertion, predicate, or production code changed; no behaviour
change beyond closing the handle deterministically.

Long-function splits and server.py module split intentionally not
included: the longest functions (_dispatch, _create_task,
_dispatch_project, ~375-395 lines in a 10430-line server.py) are
central routing/creation paths, and splitting them is not low-risk;
see PR body.
2026-11-03 02:48:54 +00:00

150 lines
6.2 KiB
Python

"""Worker wiring for ChatGPT-Codex-alignment skills: tenant seeding.
Mirrors test_websearch_worker.py: no Docker, no network, no real
model. _tenant_dirs runs against temp dirs; the skill pack used
here is the real cloud/skills/ pack, so a broken pack fails here
before it ever reaches a tenant.
"""
import os
import sys
import tempfile
import unittest
from pathlib import Path
try:
from cloud.server import init_db
from cloud.worker import Worker
from cloud.skill_seed import ensure_codex_home_skills, list_skills
except ImportError:
sys.path.insert(0, str(Path(__file__).resolve().parents[2]))
from cloud.server import init_db
from cloud.worker import Worker
from cloud.skill_seed import ensure_codex_home_skills, list_skills
class SkillSeedHelperTestCase(unittest.TestCase):
def setUp(self):
self.tmp = tempfile.TemporaryDirectory()
def tearDown(self):
self.tmp.cleanup()
def _src(self):
src = os.path.join(self.tmp.name, "pack")
for name in ("live-info", "document-tools"):
d = os.path.join(src, name)
os.makedirs(d, exist_ok=True)
Path(os.path.join(d, "SKILL.md")).write_text(
"---\nname: %s\ndescription: test\n---\nbody\n" % name,
encoding="utf-8")
return src
def test_copy_idempotent_and_missing_source(self):
home = os.path.join(self.tmp.name, "home")
out = ensure_codex_home_skills(home, self._src())
self.assertEqual(sorted(out["skills_copied"]),
["document-tools", "live-info"])
self.assertEqual(out["skills_skipped_differ"], [])
out2 = ensure_codex_home_skills(home, self._src())
self.assertEqual(out2["skills_copied"], [])
out3 = ensure_codex_home_skills(
os.path.join(self.tmp.name, "home2"),
os.path.join(self.tmp.name, "no-such-pack"))
self.assertEqual(out3["skills_copied"], [])
def test_tenant_modified_skill_is_never_overwritten(self):
home = os.path.join(self.tmp.name, "home")
src = self._src()
ensure_codex_home_skills(home, src)
dest = os.path.join(home, "skills",
"live-info", "SKILL.md")
Path(dest).write_text("tenant edited version\n", encoding="utf-8")
out = ensure_codex_home_skills(home, src)
self.assertEqual(out["skills_skipped_differ"], ["live-info"])
self.assertEqual(Path(dest).read_text(encoding="utf-8"), "tenant edited version\n")
def test_real_pack_lists_all_skills(self):
names = [n for n, _p in list_skills()]
self.assertEqual(names,
["browser-automation", "document-tools",
"image-workflow", "live-info",
"software-engineering"])
class WorkerSkillSeedTestCase(unittest.TestCase):
def setUp(self):
self.tmp = tempfile.TemporaryDirectory()
self.db_path = os.path.join(self.tmp.name, "control.db")
init_db(self.db_path)
self.template_home = os.path.join(self.tmp.name, "tpl-home")
os.makedirs(self.template_home)
Path(os.path.join(self.template_home, "config.toml")).write_text(
'[model_provider.xcmapi]\n'
'base_url="https://xcmapi.org/v1"\n', encoding="utf-8")
self.template_repo = os.path.join(self.tmp.name, "tpl-repo")
os.makedirs(os.path.join(self.template_repo, ".git"))
Path(os.path.join(self.template_repo, "sample.py")).write_text(
"def add(a, b):\n return a + b\n", encoding="utf-8")
def tearDown(self):
self.tmp.cleanup()
def _worker(self, **kwargs):
kwargs.setdefault("env", {"XCM_API_KEY": "test-placeholder"})
kwargs.setdefault("tenants_root",
os.path.join(self.tmp.name, "tenants"))
kwargs.setdefault("tenant_template_home", self.template_home)
kwargs.setdefault("tenant_template_repo", self.template_repo)
kwargs.setdefault("tenant_isolation", True)
return Worker(self.db_path, "/fake/host.py", **kwargs)
def _skill_path(self, dirs, name):
return os.path.join(dirs["codex_home"], "skills",
name, "SKILL.md")
def test_flag_off_is_old_behaviour(self):
worker = self._worker()
self.assertFalse(worker.seed_skills)
dirs = worker._tenant_dirs("projA")
self.assertFalse(os.path.exists(
os.path.join(dirs["codex_home"], "skills")))
def test_flag_on_seeds_real_pack(self):
worker = self._worker(seed_skills=True)
dirs = worker._tenant_dirs("projA")
for name in ("live-info", "document-tools", "image-workflow"):
path = self._skill_path(dirs, name)
self.assertTrue(os.path.exists(path), path)
self.assertIn("name: %s" % name, Path(path).read_text(encoding="utf-8"))
def test_flag_on_seeds_software_engineering_and_user_edit_survives(self):
worker = self._worker(seed_skills=True)
dirs = worker._tenant_dirs("projA")
path = self._skill_path(dirs, "software-engineering")
self.assertTrue(os.path.exists(path), path)
text = Path(path).read_text(encoding="utf-8")
self.assertIn("name: software-engineering", text)
# v0.2 P0-1: the appendix travels inside SKILL.md itself,
# because skill_seed only copies SKILL.md, not templates/.
self.assertIn("附录角色:00-coordinator", text)
self.assertIn("附录角色:08-shared-core", text)
Path(path).write_text("tenant edited version\n", encoding="utf-8")
worker._tenant_dirs("projA")
self.assertEqual(Path(path).read_text(encoding="utf-8"), "tenant edited version\n")
def test_old_tenant_merges_and_user_edit_survives(self):
worker = self._worker()
dirs = worker._tenant_dirs("projA")
worker2 = self._worker(seed_skills=True)
worker2._tenant_dirs("projA")
path = self._skill_path(dirs, "live-info")
self.assertTrue(os.path.exists(path))
Path(path).write_text("tenant edited version\n", encoding="utf-8")
worker2._tenant_dirs("projA")
self.assertEqual(Path(path).read_text(encoding="utf-8"), "tenant edited version\n")
if __name__ == "__main__":
unittest.main()